fix: mapping build phases with exceptions #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortmarek
commented
Feb 18, 2025
Comment on lines
+11
to
+12
| } else { | ||
| return "Unknown" |
Member
Author
There was a problem hiding this comment.
fly-by fix: The bundle identifier can defined in an xcconfig in which case we don't read it. To properly fix this, we should read and parse xcconfigs to get the correct value. For now, we default to Unknown instead of failing when the project is correctly defined.
fortmarek
commented
Feb 18, 2025
| { | ||
| let path = try AbsolutePath(validating: pathString) | ||
| if try await fileSystem.exists(path, isDirectory: true), | ||
| if (try? await fileSystem.exists(path, isDirectory: true)) ?? false, |
Member
Author
There was a problem hiding this comment.
fly-by fix: if path is not valid, we'd throw here. Instead, we default to false now
fortmarek
commented
Feb 18, 2025
Package.swift
Outdated
Comment on lines
83
to
86
| .package( | ||
| url: "https://github.com/adincebic/XcodeProj", | ||
| branch: "support/PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet" | ||
| ), |
Member
Author
There was a problem hiding this comment.
Once the prerequisite PR is merged, will move this back to tuist/XcodeProj
pepicrft
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for correctly mapping build phase file references from synchronized groups.
The support for the
PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSetinXcodeProjis added via tuist/XcodeProj#894