fix: correctly map project target framework #113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mapping a target framework from a different project, we would incorrectly default to a
.targetframework dependency. To fix this, we are constructing a map of target names to aProjectNativeTarget– a helper struct that contains the necessary models we need to return aTargetDependency.project.Additionally, we are now reading
buildSettingsof a given target framework to derive thelinkingStatus.