fix: expand synchronized groups when mapping a PBXTarget #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortmarek
force-pushed
the
fix/mapper-synchronized-groups
branch
from
3290189 to
d53d50d
Compare
fortmarek
force-pushed
the
fix/mapper-synchronized-groups
branch
from
d53d50d to
e040520
Compare
ajkolean
reviewed
Feb 6, 2025
Collaborator
ajkolean
left a comment
ajkolean
left a comment
There was a problem hiding this comment.
Great updates! 💯 A couple of potential points to polish further
pepicrft
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mapping
PBXTargettoTarget, when thePBXTargethas buildable groups, this information gets lost during the mapping sinceTargethas no notion of these.Since having the right set of sources, resources, headers, and frameworks is crucial for correct hashes, we need to ensure this information does not get lost.
The fix is to expand the buildable groups into lists of sources, resources, etc. that are then passed to the final
Target.cc @ajkolean