Feature periodic score #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
A-Tarraf
reviewed
Aug 22, 2025
Member
A-Tarraf
left a comment
A-Tarraf
left a comment
There was a problem hiding this comment.
Some minor issues. The test needs to be fixed, as the arguments for autocorrelation changed. I'll fix the bugs
| f"{phi_array[i]:.3e}", | ||
| wave_name, | ||
| ) | ||
| if len(periodicity_array) > 0: |
Member
There was a problem hiding this comment.
overkill, can be simplified for future versions
- Reworked periodicity detection logic for increased modularity and flexibility. - Standardized argument handling by replacing boolean defaults with `None` for clarity. - Updated test cases and documentation to reflect changes (`README.md`, `args.py`). - Optimized output generation with dynamic table column generation. - Removed redundant and commented-out code for cleaner implementation. - Enhanced script execution to support refined periodicity methods: RPDE, SF, correlation, and individual period correlation.
A-Tarraf
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new periodicity score, including RPDE, Spectral Flatness Entropy Methods and a correlation approach to determine how periodic the signal is in the entire signal or parts of the signal with a specific frequency.