Skip to content

Merge dev into main #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ttqureshi wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

Merge dev into main #4

ttqureshi wants to merge 29 commits into from

Conversation

@ttqureshi
Copy link
Owner

@ttqureshi ttqureshi commented Jul 15, 2024 •
edited
Loading

To get the weather extremes of a year: python3 main.py ./ -e 2012:

Output:
<==== Report for the year 2012: ====>
Highest: 32C on June 21
Lowest: -4C on January 10
Humidity: 100% on January 18

To get the average stats of a month: python3 main.py ./ -a 2009/4

Output:

<==== Report for the month: April 2009 ====>
Highest Average: 17.2C
Lowest Average: 10.7C
Average Mean Humidity: 44.0%

To get the daily temperature bar charts of a month: python3 main.py ./ -c 2010/7

Output:

<==== Temperature Bar Charts for July 2010 ====>
1 +++++++++++++++++++++++++++ 27C
1 +++++++++++++++++ 17C
2 ++++++++++++++++++++++++ 24C
2 ++++++++++++++++++ 18C
3 ++++++++++++++++++++++++++ 26C
3 ++++++++++++++++++ 18C
4 ++++++++++++++++++++++++ 24C
4 +++++++++++++++ 15C
5 +++++++++++++++++++++++++ 25C
5 ++++++++++++++++ 16C
6 +++++++++++++++++++++++ 23C
6 ++++++++++++++++ 16C
7 +++++++++++++++++++++++ 23C
7 ++++++++++++++++ 16C
...

To get highest and lowest temperature bar chart of a day in one line: python3 main.py ./ -c 2010/7 --inline

Output:

<==== Temperature Bar Charts for July 2010 ====>
1 +++++++++++++++++ +++++++++++++++++++++++++++ 17C - 27C
2 ++++++++++++++++++ ++++++++++++++++++++++++ 18C - 24C
3 ++++++++++++++++++ ++++++++++++++++++++++++++ 18C - 26C
4 +++++++++++++++ ++++++++++++++++++++++++ 15C - 24C
5 ++++++++++++++++ +++++++++++++++++++++++++ 16C - 25C
6 ++++++++++++++++ +++++++++++++++++++++++ 16C - 23C
7 ++++++++++++++++ +++++++++++++++++++++++ 16C - 23C
8 ++++++++++++++++++ +++++++++++++++++++++++++++ 18C - 27C
9 +++++++++++++++++++ ++++++++++++++++++++++++++ 19C - 26C
10 ++++++++++++++++++++ +++++++++++++++++++++++++ 20C - 25C
...

Multiple reports at a time: python3 main.py ./ -c 2010/7 -a 2009/4 -e 2012 --inline

Output:

<==== Report for the year 2012: ====>
Highest: 32C on June 21
Lowest: -4C on January 10
Humidity: 100% on January 18

<==== Report for the month: April 2009 ====>
Highest Average: 17.2C
Lowest Average: 10.7C
Average Mean Humidity: 44.0%

<==== Temperature Bar Charts for July 2010 ====>
1 +++++++++++++++++ +++++++++++++++++++++++++++ 17C - 27C
2 ++++++++++++++++++ ++++++++++++++++++++++++ 18C - 24C
3 ++++++++++++++++++ ++++++++++++++++++++++++++ 18C - 26C
4 +++++++++++++++ ++++++++++++++++++++++++ 15C - 24C
5 ++++++++++++++++ +++++++++++++++++++++++++ 16C - 25C
6 ++++++++++++++++ +++++++++++++++++++++++ 16C - 23C
7 ++++++++++++++++ +++++++++++++++++++++++ 16C - 23C
8 ++++++++++++++++++ +++++++++++++++++++++++++++ 18C - 27C
9 +++++++++++++++++++ ++++++++++++++++++++++++++ 19C - 26C
10 ++++++++++++++++++++ +++++++++++++++++++++++++ 20C - 25C
...

ttqureshi and others added 29 commits June 11, 2024 13:57
@ttqureshi
Implemented parser to parse files and save weather readings
1204b86
@ttqureshi
UPDATE
e8c4281
@ttqureshi
weather report for a particular year
e0bd13b
@ttqureshi
weather report generation, given a month
30130f1
@ttqureshi
Bar charts for daily temperatures of a month
e0b5443
@ttqureshi
One line bar chart
eb2e336
@ttqureshi
Add README
28434c5
@ttqureshi
Update README
b2c6ec3
@ttqureshi
Update README.md
8df84b2
@ttqureshi
Update .gitignore
efbce2b
@ttqureshi
Refactoring: Parser class implemented
55c418a
@ttqureshi
Refactoring: Parser class implemented
e93578b
@ttqureshi
Refactoring completed: Made use of classes for calculations and repor…
5b854ba 
…ting
@ttqureshi
Making suggested changes
a9bfba7 
- moved main.py outside of code_files directory and renamed it to weatherman.py
- Computations -> ReportCalculator (renamed)
- Parser -> WeatherParser (renamed)
- separate class for constants
- Using WeatherReporter for printing only. All calculations moved to ReportCalculator class
- Handled missing values in data
- If user asks for a year or month against which there is no record in the data, shows a message No Record Found instead of throwing error
@ttqureshi
NoneType exception handled
599a07a
@ttqureshi
Using datetime instead of int
b1f61ff
@ttqureshi
Help messages
90150ed
@ttqureshi
Meaningful argument names
b6d9353
@ttqureshi
Allowing multiple dates to be passed
6f2c4b5
@ttqureshi
Refactor to use OOP for ReportCalculator and WeatherReporter classes
4b32012
@ttqureshi
Formatting
29f7b39
@ttqureshi
complying with pep8 import order
f57eab6
@ttqureshi
fix argparse error
bf1e860
@ttqureshi
Refactored to reduce redundancy by instantiating ReportCalculator and…
f6bfc70 
… WeatherReporter once.
@ttqureshi
perf: Add __eq__() method
a0136e7 
This method checks for the equality of two objects of type WeatherReading
@ttqureshi
fix: validate_reading(value) in WeatherReading
a335bc9 
The older condition 'value is not None' isn't sufficient. The value can be empty (string) as well, in that case this method should not return anything. Other catch was 0 values. Therefore, first condition 'if value' filters out None and empty stirngs and the subsequent condition 'value == 0' lets 0's to pass the condition since they are desired.
@ttqureshi
Update .gitignore
d424b15
@ttqureshi
minor change: Set the default value of extract_to to None
06bb420
@ttqureshi
Organizing imports
e643841
@ttqureshi ttqureshi requested a review from irtazaakram July 15, 2024 11:22
@ttqureshi ttqureshi self-assigned this Sep 4, 2024
@ttqureshi ttqureshi marked this pull request as draft March 12, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irtazaakram irtazaakram Awaiting requested review from irtazaakram

Assignees

@ttqureshi ttqureshi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ttqureshi