Analysis table changes #14
Open
+545
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default number of rows per page in the result analysis table is still 10, but if the user changes that their choice will be remembered for next time.
Resize the result table on window resize and fill the window width.
Since the backend doesn't support it.
The export feature was only allowing for dumping the results of an entire test run. This will pass the query parameters that are being used to create the current view to the export function so that the data exported will match what the user has filtered.
Let them flow.
If multiple tags are selected by the user, the set of results will be those that include ALL the selected tags, not just any of them.
- removed unused processingTestRunStats - fixed race condition by dequeuing stat request before processing it - re-queue requests to end of queue if exception so other requests aren't starved - outcome stats only need to be calculated once, not every single time - increased sleep time between calculations
Also fixed tests to pass
When fetching test outcomes, separate database calls are made to get the paginated result data and the count of total matching results. The counting query needed to be modified to take into account changes made when including tags in the query filter so that the count number is accurate.
Calculation of the test outcome stats (streaks and success rate) for every test outcome is expensive and was starving out calculation of test run stats. This changes makes the stats service crunch stats in batches, takes breaks to let other things be processed.
This commit only adds support for tag filters. If there's tags specified as query params to this page, use them to set the defaults for the view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry these commits weren't individual pull requests as I'd planned. Changes pertain to usability enhancements to the test result analysis table. Take what you wish from it.