Skip to content

Conversation

@tsyirvo
Copy link
Owner

@tsyirvo tsyirvo commented Jan 7, 2026

Summary by CodeRabbit

  • New Features

    • Enabled over-the-air updates for production environments with configurable update URLs.
  • Chores

    • Updated CI/CD workflow to execute tests as part of quality checks.
    • Refined logging behavior to suppress debug messages outside development mode.

✏️ Tip: You can customize this high-level summary in your review settings.

@tsyirvo tsyirvo self-assigned this Jan 7, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 7, 2026

Walkthrough

This pull request updates the CI/CD workflow to run tests instead of commitlint checks, adds production-only update configuration with a URL parameter, introduces a new environment variable for update URLs, and gates console logging behind the __DEV__ flag in the logger.

Changes

Cohort / File(s) Summary
CI/CD Workflow
.github/workflows/quality.yml
Removed commitlint step and replaced it with test execution via yarn jest --coverage=false
Configuration & Environment
app.config.ts, env.js
Added production-only update configuration with EXPO_UPDATE_URL parameter; made iOS bundle identifier reference dynamic using Env.BUNDLE_ID; introduced EXPO_UPDATE_URL as required build-time environment variable
Logger
src/infra/logger/logger.ts
Conditioned dev logger output to only execute when __DEV__ flag is truthy

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'chore: update some project config' is vague and overly generic, using non-descriptive terms like 'some' that don't convey meaningful information about the specific changes made. Replace with a more specific title that highlights the main changes, such as 'chore: add EXPO_UPDATE_URL configuration and update logger behavior' or 'chore: configure production updates and improve logging'
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom Pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5255b16 and cce9e64.

📒 Files selected for processing (4)
  • .github/workflows/quality.yml
  • app.config.ts
  • env.js
  • src/infra/logger/logger.ts
🧰 Additional context used
🧬 Code graph analysis (1)
app.config.ts (1)
env.js (1)
  • Env (112-112)
🔇 Additional comments (6)
src/infra/logger/logger.ts (1)

73-78: LGTM! Good practice to gate debug logs.

Wrapping console logs behind the __DEV__ flag ensures debug output only appears in development builds, preventing unnecessary logging in production.

app.config.ts (2)

94-98: Verify EXPO_UPDATE_URL is set in all environments.

The updates configuration looks correct, enabling updates only in production. However, since Env.EXPO_UPDATE_URL is always referenced (even when enabled: false in dev/staging), ensure that this environment variable is provided in all environment files (.env.development, .env.staging, .env.production), as the schema validation in env.js requires it.

Based on the environment configuration in env.js, line 54 defines EXPO_UPDATE_URL as a required string in the buildTime schema.


114-116: LGTM! Consistent with bundle identifier configuration.

The change to use Env.BUNDLE_ID in the OneSignal group identifier aligns with line 102 where bundleIdentifier is also set to Env.BUNDLE_ID, ensuring consistency across the iOS configuration.

env.js (2)

54-54: Confirm EXPO_UPDATE_URL is set in all environment files.

The new EXPO_UPDATE_URL variable is defined as required in the buildTime schema, meaning it must be present in all environment configuration files (.env.development, .env.staging, .env.production). Since updates are only enabled in production (per app.config.ts line 95), ensure non-production environment files contain appropriate placeholder values for this variable.


86-86: LGTM! Consistent with schema definition.

The environment variable is correctly read from process.env and matches the schema requirement defined at line 54.

.github/workflows/quality.yml (1)

46-47: No action needed. Verification confirms that commitlint is not configured anywhere in the repository and is not handled in any workflow. The step change to run jest tests is intentional and appropriate.


Comment @coderabbitai help to get the list of available commands and usage tips.

@tsyirvo tsyirvo merged commit 1effaad into develop Jan 7, 2026
2 checks passed
@tsyirvo tsyirvo deleted the chore/configurationUpdates branch January 7, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants