Fix up SQL concatenation #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@ottenhoff I think (correct me if I am wrong) you sent this to tsugi and then re-sent it to tsugi-php. It turns out that it is easiest for me to take it at tsugi and then hand move it to tsugi-php. Even though there is manual effort on my part to test this PR I need it in tsugi. Then I can test a branch - then I can merge it and round trip the code through tsugi-php. On a side note, I am thinking of collapsing tsugi-php into tsugi/lib so there is one repo. I want to still be able to release tsugi-php thought packagist - chatGPT tells me this is possible if I am careful so I am looking into that. |
Author
This makes good sense to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.