Skip to content

allow plain scalars under JSON #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wchristian wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow plain scalars under JSON #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Data/FlexSerializer.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ use Constant::FromGlobal DEBUG => { int => 1, default => 0, env => 1 };

use List::Util qw(min);
use Storable qw();
use JSON::XS qw();
use JSON::XS 4 qw();
use Sereal::Decoder qw();
use Sereal::Encoder qw();
use Compress::Zlib qw(Z_DEFAULT_COMPRESSION);
Expand Down
6 changes: 3 additions & 3 deletions t/10basic.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,10 @@ foreach my $class ('Data::FlexSerializer', 'Data::FlexSerializer::EmptySubclass'
$res = $serializer->serialize($data{garbage});
1;
};
if ($is_sereal) {
ok(!$eval_died, "Under Sereal we support serializing plain SvPV");
if ($is_sereal or $s_name =~ /^(json|flex|default)/) {
ok(!$eval_died, "Under Sereal and JSON we support serializing plain SvPV");
} else {
ok($eval_died, "We should die under Storable and JSON when fed a plain SvPV");
ok($eval_died, "We should die under Storable when fed a plain SvPV");
}
}

Expand Down