Fix crash on simulation loading caused by missing signal actions list#49
Open
orwell96 wants to merge 1 commit intots2:masterfrom
Open
Fix crash on simulation loading caused by missing signal actions list#49orwell96 wants to merge 1 commit intots2:masterfrom
orwell96 wants to merge 1 commit intots2:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
- Coverage 76.26% 73.77% -2.50%
==========================================
Files 38 38
Lines 2600 2208 -392
==========================================
- Hits 1983 1629 -354
+ Misses 494 459 -35
+ Partials 123 120 -3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title says, this fixes a crash when loading a previously saved simulation
It appears to happen as a result of the signal actions not being saved in the JSON file.
OT: You are probably no longer maintaining and continuing this project. I don't expect you to actually review and merge this.
As I am actually pretty impressed by the work you put into this project, and am sad to see this lie around unfinished, I have decided to fork and continue it, although starting off from 0.6. If you're interested: https://github.com/orwell96/ts2-fork