feat(ecmascript): Make Math.sumPrecise actually precise
#915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing implementation of `Math.sumPrecise` did `f64` addition, which could result in precision losses and overflows due to intermediate results. This patch fixes this by using the xsum crate instead. Additionally, since the `Math.sumPrecise` proposal has been stage 4 since July 2025, this patch removes the `proposal-math-sum` feature and enables it by default.
aapoalas
reviewed
Dec 13, 2025
aapoalas
approved these changes
Dec 13, 2025
Member
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
LGTM, and this is really nice in general! Thank you <3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation of
Math.sumPrecisedidf64addition, which could result in precision losses and overflows due to intermediate results. This patch fixes this by using the xsum crate instead.Additionally, since the
Math.sumPreciseproposal has been stage 4 since July 2025, this patch removes theproposal-math-sumfeature and enables it by default.