-
Notifications
You must be signed in to change notification settings - Fork 236
[comp] Production Deploy #2010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release
Are you sure you want to change the base?
[comp] Production Deploy #2010
Conversation
* feat(integrations): add multi-select with branch inputs for GitHub repos * feat(integrations): enhance task integration checks with passing results display --------- Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
PR SummaryEnhances onboarding, vendor UX, and GitHub integration checks.
Written by Cursor Bugbot for commit 2589533. This will update automatically on new commits. Configure here. |
|
|
* feat(onboarding): add support for custom vendors with website URLs in onboarding process * feat(onboarding): enhance custom vendor handling in onboarding process --------- Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
#2012) Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
* feat(onboarding): enhance vendor information handling in onboarding tracker * feat(onboarding): normalize vendor names for deduplication across components * feat(onboarding): improve vendor assessment progress calculation with deduplication --------- Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
apps/app/src/app/(app)/[orgId]/vendors/(overview)/components/VendorsTable.tsx
Outdated
Show resolved
Hide resolved
…sment (#2014) Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
…ble (#2015) Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| // Completed is the max of DB assessed vendors or metadata completed | ||
| const completed = Math.max(completedCount, completedInMetadata); | ||
| const total = uniqueVendorStatuses.size; | ||
| const completed = Array.from(uniqueVendorStatuses.values()).filter((v) => v.isCompleted).length; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Progress counter inconsistent with table vendor deduplication
Medium Severity
The assessmentProgress calculation deduplicates all vendors (including real DB vendors) by normalized name, while dedupedVendors explicitly preserves all real DB vendors without deduplication. This mismatch means if two real vendors exist with names that normalize to the same value (e.g., "Slack" and "Slack Inc"), the table shows both rows but the progress counter treats them as one. If only one is completed, progress shows "1/1" (complete) while a pending vendor is still visible in the table. The comment claims the progress calculation "matches the table" but the logic does not.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.