-
Notifications
You must be signed in to change notification settings - Fork 236
[comp] Production Deploy #2002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[comp] Production Deploy #2002
Conversation
* feat(pdf): add functionality to delete policy PDFs and handle PDF merging * fix(api): bug and change pdf view * fix: upgrade del action and replace action * fix: rollback in fail for UI --------- Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryPolicy exports & PDF management
Storage & S3
Assistant chat (ephemeral context)
Vendor risk assessment improvements
Tasks & DB
Other
Written by Cursor Bugbot for commit 878ac95. This will update automatically on new commits. Configure here. |
|
|
…ux (#2003) * feat(pdf): enhance PDF rendering with organization color and watermark * fix(api): handle invalid primary color format in PDF rendering * feat(api): add endpoint to download all policies as ZIP with PDFs * fix(api): handle fallback for non-ASCII names in safe filename conversion * fix(api): handle archive errors in ZIP creation process * fix(api): correct footer font usage in PDF rendering --------- Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
| const watermarkText = | ||
| customWatermarkText || | ||
| `For: ${name} <${email}> | ${timestamp} | ID: ${agreementId}`; | ||
| const watermarkText = 'CompAI'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom watermark text parameter ignored in PDF watermarking
Low Severity
The addWatermark method accepts a customWatermarkText parameter but completely ignores it, hardcoding watermarkText to 'CompAI'. The watermarkExistingPdf method passes a watermarkText parameter through to addWatermark, and at least one caller (getComplianceResourceUrlByAccessToken) explicitly passes 'Comp AI' expecting it to be used. The custom text will be silently ignored, which breaks the function's contract with its callers.
Additional Locations (1)
apps/app/src/app/(app)/[orgId]/policies/[policyId]/editor/components/PolicyDetails.tsx
Show resolved
Hide resolved
* refactor(api): improve code formatting and structure in assistant chat files * refactor(pdf): streamline PDF merging logic and enhance error handling --------- Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
…rking (#2005) Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
apps/app/src/app/(app)/[orgId]/policies/[policyId]/editor/components/PolicyDetails.tsx
Show resolved
Hide resolved
…cies (#2007) Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
* feat(tasks): add automation status to task creation and regeneration * refactor(tasks): remove logging from regenerate task action --------- Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
apps/app/src/app/(app)/[orgId]/policies/all/components/policies-table.tsx
Show resolved
Hide resolved
apps/app/src/app/(app)/[orgId]/policies/[policyId]/editor/components/PolicyDetails.tsx
Show resolved
Hide resolved
| width: 10, | ||
| height: 26, | ||
| color: rgb(accentColor.r, accentColor.g, accentColor.b), | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Policy header rectangle overlaps original PDF content
Medium Severity
For non-first uploaded PDFs in the merged bundle, the policy header rectangle is positioned at yPos - 40 where yPos = height + 60 - 25 = height + 35. This places the rectangle at y = height - 5, which is 5 pixels below the top of the embedded original PDF content (which occupies y = 0 to y = height). The 26-pixel tall rectangle thus overlaps with the original document content. For first policies, the math works correctly because yPos is adjusted by an additional -34 after drawing the org header, but this adjustment is skipped for subsequent policies.
Additional Locations (1)
* feat(s3): add optional AWS endpoint configuration for S3-compatible provider support * feat(s3): make S3 endpoint optional and adjust forcePathStyle configuration Signed-off-by: Andreas Reußner <andreas.reussner@outlook.de> * fix(s3): handle undefined endpoint for S3 client initialization Signed-off-by: Andreas Reußner <andreas.reussner@outlook.de> --------- Signed-off-by: Andreas Reußner <andreas.reussner@outlook.de> Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
|
🎉 This PR is included in version 1.77.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.