-
Notifications
You must be signed in to change notification settings - Fork 237
[comp] Production Deploy #1930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[comp] Production Deploy #1930
Conversation
* fix(app): add orgId query parameter to /api/cloud-tests/providers endpoint * fix(app): add auth check to api/cloud-tests/providers endpoint * fix(app): verify if the user belongs to the org in cloud-tests/provider endpoint * fix(app): update cloud-tests/findings endpoint to have orgId as query param --------- Co-authored-by: chasprowebdev <chasgarciaprowebdev@gmail.com> Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
PR SummaryAdds a Trigger.dev build extension and CI steps to include the workspace integration-platform, scopes cloud-tests API/UI by orgId with stricter auth, and always shows task automations when present.
Written by Cursor Bugbot for commit 912f418. This will update automatically on new commits. Configure here. |
Graphite Automations"Auto-assign PRs to Author" took an action on this PR • (12/16/25)1 reviewer was added to this PR based on Mariano Fuentes's automation. |
* fix(app): update custom automations section to show based on conditions * chore(api): add integration platform extension and update workflows
| context.logger.log( | ||
| 'Copied @comp/integration-platform to deployment bundle', | ||
| ); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing AWS SDK dependencies cause runtime deployment failures
The integrationPlatformExtension copies the @comp/integration-platform dist files to the Trigger.dev deployment but doesn't install its runtime dependencies. The integration-platform package (built with plain tsc, not bundled) requires @aws-sdk/client-cloudtrail and @aws-sdk/client-iam, which are not in apps/api/package.json and won't be available at runtime. Unlike the customPrismaExtension which uses context.addLayer() to ensure dependencies are installed, this extension only copies files. The deployment will fail at runtime when code tries to import these missing AWS SDK packages.
* chore(workflows): add integration platform package installation and build steps
| path: resolve(packagePath, 'dist', `${subpath}/index.js`), | ||
| }; | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Subpath resolution incorrectly appends /index.js for flat exports
The subpath import resolution unconditionally appends /index.js to the subpath, which doesn't match the package's actual export structure. According to @comp/integration-platform's package.json, the ./types export maps to ./dist/types.js, not ./dist/types/index.js. When resolving @comp/integration-platform/types, the code produces dist/types/index.js instead of the correct dist/types.js. This would cause build failures if any Trigger.dev task imports from the /types subpath.
|
🎉 This PR is included in version 1.72.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.