[comp] Production Deploy #1924
[comp] Production Deploy #1924
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryAdds device unlink API/UX with FleetDM cleanup, onboarding user menu/sign-out and skip, self-hosting docs and Docker logging improvements, enhanced GitHub sanitized-inputs check, and browser automation eval tweaks.
Written by Cursor Bugbot for commit 5912194. This will update automatically on new commits. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| success: true, | ||
| screenshotUrl: presignedUrl, | ||
| evaluationStatus: 'pass', | ||
| evaluationStatus: result.evaluationStatus, |
There was a problem hiding this comment.
Bug: Successful runs now return undefined evaluationStatus instead of pass
The executeAutomation method no longer returns evaluationStatus in its success path (it only returns success, screenshot, and evaluationReason). However, the calling code at lines 559 and 699 still returns evaluationStatus: result.evaluationStatus, which will be undefined. Previously these lines returned a hardcoded 'pass'. This changes the API contract for successful automation runs from returning evaluationStatus: 'pass' to evaluationStatus: undefined, which could break API consumers expecting this field.
Additional Locations (2)
Graphite Automations"Auto-assign PRs to Author" took an action on this PR • (12/15/25)1 reviewer was added to this PR based on Mariano Fuentes's automation. |
* feat(ui)(sidebar): remove old sidebar components and update dependencies * feat(ui): enhance organization switcher with dropdown menu and sorting options * revert(ui): sheet ui * fix(ui): type fix * fix: tooltip leak --------- Co-authored-by: Daniel Fu <itsnotaka@gmail.com>
|
|
* feat(docker): add logging configuration and update Dockerfile for integration platform * fix(docker): add restart policy and correct healthcheck URL * refactor(docker): simplify dependency installation command in Dockerfile * chore(bun.lock): update @jridgewell/trace-mapping to version 0.3.31 --------- Co-authored-by: Daniel Fu <itsnotaka@gmail.com> Co-authored-by: Min Chun Fu <70210356+Itsnotaka@users.noreply.github.com>
* feat(app): create alert for removing device * feat(api): create endpoint for unlinking device * feat(app): integrate unlink-device endpoint on click of 'Remove Device' menu * fix(app): hide Remove Device menu if the current user is not an owner * feat(app): integrate fleet endpoint to delete the hosts * fix(app): refresh after unlinking device * fix(app): remove unused variable --------- Co-authored-by: chasprowebdev <chasgarciaprowebdev@gmail.com> Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
* chore(bun.lock): downgrade configVersion from 1 to 0 * chore(api): update tsconfig path mappings and output directory * feat(layout): add variant prop to MinimalHeader for onboarding and setup --------- Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
| }; | ||
| } catch (error) { | ||
| this.logger.error(`Failed to remove hosts for label ${fleetDmLabelId}:`, error); | ||
| throw new Error(`Failed to remove hosts for label ${fleetDmLabelId}: ${error.message}`); |
There was a problem hiding this comment.
Bug: Unsafe error.message access without type checking
The catch block accesses error.message directly without verifying error is an Error object. In JavaScript, caught exceptions can be any type. If the exception is a string, number, or other non-Error value, error.message will be undefined, producing a confusing error message like "Failed to remove hosts for label X: undefined". Other error handlers in this file (lines 54-57, 64-67) correctly avoid this pattern.
| }, | ||
| }, | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Bug: Sign out failure leaves button permanently disabled
The handleSignOut function sets isSigningOut to true but never resets it if authClient.signOut() fails. If a network error or server error occurs during sign out, the button remains stuck in the disabled "Signing out..." state with no way to retry. The function lacks error handling (try-catch/finally) to reset the loading state on failure.
|
🎉 This PR is included in version 1.71.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.