-
Notifications
You must be signed in to change notification settings - Fork 243
[comp] Production Deploy #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
[comp] Production Deploy #1348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or Fleet setup - Replaced environment variable references for device paths with hardcoded values for macOS and Windows. - Enhanced SQL queries in `createFleetLabelForOrg` and `createFleetLabel` functions to include additional fallback paths and registry checks. - Refactored script generation logic for macOS and Windows, improving clarity and adding detailed logging for setup processes. - Introduced common utility functions for script filename and package retrieval, promoting code reuse and maintainability.
- Introduced console logs in `getEmployeeDevices` to track organization ID and device retrieval processes. - Added logging in `EmployeeDevicesPage` to display fetched devices. - Normalized SQL queries in `createFleetLabelForOrg` and `createFleetLabel` for improved readability and consistency.
…ions - Eliminated console logs in `getEmployeeDevices` and `EmployeeDevicesPage` to clean up the code and improve performance. - Streamlined the device retrieval process by focusing on essential functionality without debug statements.
…mpai/comp into mariano/agent-improvements
[dev] [Marfuen] mariano/agent-improvements
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…ration - Added runtime, dynamic, and maxDuration settings for the download agent. - Implemented robust error handling for archiving and S3 streaming processes to improve reliability. - Introduced logging for various error scenarios to facilitate debugging and monitoring.
[dev] [Marfuen] mariano/agent-improvements
…tion components - Eliminated the `isFleetEnabled` checks from various components, simplifying the logic and ensuring the 'Device' tab is always displayed. - Updated related components to directly render device information without conditional rendering based on fleet feature availability. - Cleaned up imports and props to reflect the removal of fleet feature dependencies.
[dev] [Marfuen] mariano/agent-improvements
- Changed references from CHOSEN_DIR to MARKER_DIR for improved clarity and consistency in file path handling. - Ensured that marker files are written and permissions are set correctly using the updated MARKER_DIR variable. - Enhanced logging messages to reflect the new directory variable for better debugging.
- Updated the PowerShell command to use '%comspec%' for improved compatibility and added argument handling for better execution context. - Ensured the working directory is set correctly to maintain the script's operational context during execution.
[dev] [Marfuen] mariano/agent-improvements
…rience - Updated the script to create a temporary VBS file for elevating permissions, improving the user experience during setup. - Added clear messaging to inform users about the elevation process and the behavior of the new window. - Ensured the temporary VBS file is deleted after execution to maintain a clean environment.
[dev] [Marfuen] mariano/agent-improvements
- Improved the elevation process by allowing users to choose between automatic elevation and manual execution as Administrator. - Updated messaging to provide clearer instructions during the elevation process. - Added exit codes for better error handling and logging throughout the script execution. - Ensured consistent use of the MARKER_DIR variable for file path handling and improved logging for error scenarios.
[dev] [Marfuen] mariano/agent-improvements
fix: improve variable handling and logging in Windows script
- Introduced a logging mechanism to capture messages and command executions, improving visibility during script execution. - Updated directory handling to switch log files based on the chosen directory, ensuring logs are correctly maintained. - Enhanced error reporting for marker file writing and permission setting, providing clearer feedback on issues encountered during execution.
fix: enhance logging and error handling in Windows script
- Added structured comments to improve readability and organization of the script. - Enhanced logging messages for better clarity during execution, particularly for directory selection and permission settings. - Improved error handling and messaging for missing marker files, ensuring clearer feedback on script status.
fix: enhance structure and logging in Windows script
- Removed redundant echo statements to improve script clarity and reduce clutter in the output. - Introduced a main subroutine to organize script flow and enhance readability. - Added structured comments to delineate sections of the script, improving maintainability and understanding of the code.
fix: streamline script structure and enhance logging in Windows script
- Updated directory existence checks to use wildcard matching for improved reliability. - Enhanced logging to utilize delayed variable expansion for clearer output during execution. - Ensured consistent logging of chosen directory and log file paths for better visibility.
[dev] [Marfuen] mariano/agent-improvements
- Updated directory paths to use double backslashes for proper formatting in Windows. - Ensured consistency in path definitions to prevent potential parsing issues during execution.
fix: correct Windows path formatting in fleet label creation script
Marfuen
approved these changes
Aug 20, 2025
Contributor
|
🎉 This PR is included in version 1.51.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.