Skip to content

[comp] Production Deploy #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marfuen merged 2 commits into from
Aug 13, 2025
Merged

[comp] Production Deploy #1312

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d582d40
feat: add header value sanitization for S3 metadata
Marfuen Aug 13, 2025
05931fa
Merge pull request #1311 from trycompai/mariano/fix-upload
Marfuen Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion apps/api/src/attachments/attachments.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ export class AttachmentsService {
Body: fileBuffer,
ContentType: uploadDto.fileType,
Metadata: {
originalFileName: uploadDto.fileName,
// S3 metadata becomes HTTP headers (x-amz-meta-*) and must be ASCII without control chars
originalFileName: this.sanitizeHeaderValue(uploadDto.fileName),
organizationId,
entityId,
entityType,
Expand Down Expand Up @@ -273,6 +274,18 @@ export class AttachmentsService {
return fileName.replace(/[^a-zA-Z0-9.-]/g, '_');
}

/**
* Sanitize header value for S3 user metadata (x-amz-meta-*) to avoid invalid characters
* - Remove control characters (\x00-\x1F, \x7F)
* - Replace non-ASCII with '_'
* - Trim whitespace
*/
private sanitizeHeaderValue(value: string): string {
const withoutControls = value.replace(/[\x00-\x1F\x7F]/g, '');
const asciiOnly = withoutControls.replace(/[^\x20-\x7E]/g, '_');
return asciiOnly.trim();
}

/**
* Map MIME type to AttachmentType enum
*/
Expand Down
Loading