Update models + Handle verify signature for empty/not sent fields #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ReturnToAppURL Deprecate urlSheme Add @Getter to method and uuid Update signer to take a JsonNode dataNode for verifying signature to handle null/not send values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this PR is to fix the cancel notification throwing exception due to testing servers is sending two new properties.
This also addresses the 3 issues I've created
#33
#34
#35
lastorderstepandorderstatusestoCancelNotificationDataReturnToAppURLtoAbstractAccountDataAttributesurlShemeinAbstractAccountDataAttributes@Gettertomethodanduuidfor easier access to themJsonRpcSigner.verifyto take aJsonNodedataNode for verifying signature to handle null/not send values if Trustly sever does not send those valuesI was also thinking of disabling
DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIESon the object mapper inTrustlyApiClientso the parsing don't crash if Trustly server sends a new value. I left it out here.I have validated locally that the cancel notification now works and don't throw any exception and the verifying of signature also work.