Added ability to use custom resolver#91
Open
ghost wants to merge 2 commits intotrusteddomainproject:developfrom
Open
Added ability to use custom resolver#91ghost wants to merge 2 commits intotrusteddomainproject:developfrom
ghost wants to merge 2 commits intotrusteddomainproject:developfrom
Conversation
added 2 commits
May 17, 2018 14:08
resolver for a library. Especially useful for tests, but also needed to integrate into environments where other DNS resolution infrastructure is used.
Member
|
The "user" pointer, as I recall, was used in OpenDKIM to carry a handle to an initialized libunbound instance. It wasn't used for the bind case. |
mskucherawy
requested changes
Sep 17, 2018
Member
mskucherawy
left a comment
There was a problem hiding this comment.
This doesn't include hooks for setting arcl_dns_init or arcl_dns_callback. Could you add those?
60 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Murray, I used this to override the internal use of libresolv and such to
connect to PowerMTA's internal resolver, as well as to be able to provide
test DNS responses.
Since we're really only initializing the resolver library, whatever it may be,
once per ARC_LIB, I opted for a simple approach where I passed in the
library handle.
Alternatively, we could instead pass in an
arc_dns_initfunction pointer,but in this case I'd need to be able to pass in a "user data" pointer, as in