Quote results in Authentication-Results if necessary#145
Open
glts wants to merge 1 commit intotrusteddomainproject:developfrom
Open
Quote results in Authentication-Results if necessary#145glts wants to merge 1 commit intotrusteddomainproject:developfrom
glts wants to merge 1 commit intotrusteddomainproject:developfrom
Conversation
andreasschulze
pushed a commit
to andreasschulze/OpenARC
that referenced
this pull request
Jan 20, 2024
flowerysong
pushed a commit
to flowerysong/OpenARC
that referenced
this pull request
Feb 6, 2024
futatuki
added a commit
to futatuki/OpenARC
that referenced
this pull request
Sep 16, 2024
Quote results in Authentication-Results if necessary trusteddomainproject#145
60 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed change fixes a bug where OpenARC produces syntactically invalid
Authentication-Resultsheaders, by applying quoting to the result values where appropriate. It also fixes an off-by-one error when producing thearc.chainresult value.This fixes #143.