fix: support structure of anthropic/skills repository#7
Merged
trieloff merged 2 commits intotrieloff:mainfrom Oct 31, 2025
Merged
fix: support structure of anthropic/skills repository#7trieloff merged 2 commits intotrieloff:mainfrom
trieloff merged 2 commits intotrieloff:mainfrom
Conversation
The agent-skills branch was merged into main and deleted, so the tests now use the main branch without the -b flag. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Lars Trieloff <lars@trieloff.net>
Owner
|
thank you David, I've invited you as a contributor, so you can run gh actions in further prs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6.
The Problem
The script uses set -Eeo pipefail for strict error handling. When it encountered lines like:
((count++))
With set -e, this caused the script to exit immediately when count was 0, because ((count++)) post-increments and returns the OLD value (0), which bash interprets as a failure exit code.
The Fix
I replaced all 4 instances of ((var++)) with var=$((var + 1)):
upskill:129 - In the process_skills_directory function (inside generate_discover_skills)
upskill:247 - In the list_skills functionupskill:417 - In the main function (install all skills)
upskill:426 - In the main function (install selected skills)