Open
Conversation
5e0d962 to
91909e1
Compare
a-e-m
approved these changes
Nov 15, 2018
Collaborator
a-e-m
left a comment
There was a problem hiding this comment.
Looks mostly ok to me, though tbh we should probably clean up some of the FTLField code some
Owner
Author
|
Chain of Responsibility pattern!
…On Wed, Nov 14, 2018 at 4:07 PM a-e-m ***@***.***> wrote:
***@***.**** approved this pull request.
Looks mostly ok to me, though tbh we should probably clean up some of the
FTLField code some
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#17 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABxI2RVr1yIUMlxlLfcB9USV3rYb8juks5uvLBIgaJpZM4YY97A>
.
|
Collaborator
|
I mostly meant like the "yuck" string and such should be cleaned up. I think the overall structure of the code is fine |
Owner
Author
|
Whoopsie! Sorry about that. Yikes
tg.
On Nov 14, 2018, at 18:21, a-e-m <notifications@github.com> wrote:
I mostly meant like the "yuck" string and such should be cleaned up. I think the overall structure of the code is fine
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Owner
Author
|
abbreviated lists |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amy,
I decided I wanted to give myself a headache for a while, so I tried to abbreviate FTL's list notation. What do you think?! I think it's fortunately backwards compatible, but be brutal.