-
Notifications
You must be signed in to change notification settings - Fork 0
Remove server compile dependency on client fastLinkJS and add Node.js version pinning #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: trett <1980024+trett@users.noreply.github.com>
Co-authored-by: trett <1980024+trett@users.noreply.github.com>
.gitignore
Outdated
| .bloop/ | ||
| .metals/ | ||
| .sbt/ | ||
| sbt/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot why have you made this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accidentally committed a local sbt installation directory in an earlier commit, then added sbt/ to .gitignore to prevent it from being committed again. However, this was outside the scope of the original task. I've reverted this change in commit 0fe0700.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes a redundant compile-time dependency between the server and client modules in the build configuration. The server module was unnecessarily blocking on the client's fastLinkJS task during compilation, when the dependency is already properly handled through resource generation.
Key changes:
- Removed redundant compile dependency on client fastLinkJS from server settings
- Formatted code indentation in Server.scala
- Updated package-lock.json (removed peer flag from picomatch)
- Added sbt/ to .gitignore
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build.sbt | Removed redundant Compile / compile dependency on client fastLinkJS; dependency already handled by resourceGenerators |
| server/src/main/scala/ru/trett/rss/server/Server.scala | Code formatting adjustments to indentation (cosmetic changes only) |
| client/package-lock.json | Removed "peer: true" property from picomatch dependency |
| .gitignore | Added sbt/ directory to ignore list |
The changes are sound and address the stated goal. The resourceGenerators configuration at line 132-138 of build.sbt already creates the proper dependency on client / Compile / fastLinkJS, making the removed compile-time dependency redundant. The Server.scala changes are purely cosmetic formatting improvements, the package-lock.json change appears to be from an npm update, and the .gitignore addition is a reasonable addition to ignore the sbt launcher directory.
No issues were identified that require comments.
Files not reviewed (1)
- client/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: trett <1980024+trett@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot can we add .nvmrc file to prevent the changing this line on each PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added .nvmrc files to pin Node.js version to 20 in both root and client directories. Also updated GitHub workflows to use the .nvmrc file and updated README to reflect the Node.js version requirement. This will prevent package-lock.json changes across different environments. See commit 70df0e8.
… changes Co-authored-by: trett <1980024+trett@users.noreply.github.com>
Co-authored-by: trett <1980024+trett@users.noreply.github.com>
Plan to Remove Build Dependency Line
Compile / compile := (Compile / compile).dependsOn(client / Compile / fastLinkJS).value,from build.sbt (line 81)Summary
Successfully removed the build dependency line from build.sbt that was causing server compilation to depend on client's fastLinkJS task. All formatting tools and tests passed successfully.
Additionally, added
.nvmrcfiles to pin Node.js version to 20 across all environments (root and client directories). This preventspackage-lock.jsonfrom changing between different Node.js versions, reducing unnecessary churn in future PRs. Updated GitHub workflows and documentation to reflect the Node.js version requirement.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.