Consolidate client and server into single deployable unit #128
Conversation
Co-authored-by: trett <1980024+trett@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR consolidates the client and server into a single deployable unit by bundling frontend assets into server resources at build time. The changes include updating the project version in both the build configuration and Docker Compose files.
- Consolidates client and server into a single deployable unit with bundled frontend assets
- Updates project version from 2.9.9 to 2.2.9 across build and deployment configurations
- Removes the need for a separate client Docker image
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build.sbt | Updates project version to 2.2.9 |
| scripts/local-docker/docker-compose.yml | Updates server Docker image version to 2.2.9 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| server: | ||
| image: server:2.9.9 | ||
| image: server:2.2.9 |
There was a problem hiding this comment.
The version is being changed from 2.9.9 to 2.2.9, which appears to be a downgrade rather than an upgrade. This should match the version in build.sbt, but both seem to be downgrades from the previous version.
If this is meant to be an upgrade, the version should likely be 2.10.0 or 3.0.0 instead. If this truly is meant to be 2.2.9, please verify this is correct as it breaks semantic versioning conventions where versions should increment forward.
| image: server:2.2.9 | |
| image: server:2.10.0 |
* [client] simplify build * fix links * remove obsolete files * update workflow * Update server/src/main/scala/ru/trett/rss/server/Server.scala Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [WIP] Consolidate client and server into single deployable unit (#127) * Initial plan * chore: update project version to 2.9.9 Co-authored-by: trett <1980024+trett@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: trett <1980024+trett@users.noreply.github.com> * [WIP] Consolidate client into server resources (#128) * Initial plan * fix: Update project version to 2.2.9 Co-authored-by: trett <1980024+trett@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: trett <1980024+trett@users.noreply.github.com> * fix reloading --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: trett <1980024+trett@users.noreply.github.com>
Simplifies deployment from two containers (separate client/server) to a single container where the server serves both API endpoints and static frontend assets.
Changes
BASE_URI💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.