fix(benchmarks): pin dulwich<1.0.0 for DVC versions before 3.44.0#10979
Merged
fix(benchmarks): pin dulwich<1.0.0 for DVC versions before 3.44.0#10979
Conversation
Dulwich 1.0.0 removed deprecated methods including `Repo.stage()`,
which breaks scmrepo versions before 3.5.4. Since DVC only requires
scmrepo>=3 starting from version 3.44.0, older DVC versions cannot
use the fixed scmrepo and need to be pinned to dulwich<1.0.0.
This fixes dvc-bench CI failures when testing older DVC versions:
ERROR: unexpected error - 'Repo' object has no attribute 'stage'
Failure: https://github.com/treeverse/dvc-bench/actions/runs/21269812297/job/61217395932
Refs:
- jelmer/dulwich#2068
- treeverse/scmrepo#447
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dulwich 1.0.0 removed deprecated methods including
Repo.stage(), which breaks scmrepo versions before 3.5.4. Since DVC only requires scmrepo>=3 starting from version 3.44.0, older DVC versions cannot use the fixed scmrepo and need to be pinned to dulwich<1.0.0.This fixes dvc-bench CI failures when testing older DVC versions:
Failure: https://github.com/treeverse/dvc-bench/actions/runs/21269812297/job/61217395932
Refs: