Skip to content

fix: replace deprecated parseAll with parse_all in interpolate.py#10971

Merged
skshetry merged 2 commits intotreeverse:mainfrom
ritoban23:fix/parseall-deprecation-10968
Jan 16, 2026
Merged

fix: replace deprecated parseAll with parse_all in interpolate.py#10971
skshetry merged 2 commits intotreeverse:mainfrom
ritoban23:fix/parseall-deprecation-10968

Conversation

@ritoban23
Copy link
Contributor

Fixes #10968

Description

Replaced the deprecated parseAll parameter with the PEP8-compliant parse_all parameter in the parseString method call.

Changes

  • Updated line 181 in dvc/parsing/interpolate.py to use parse_all=True instead of parseAll=True

@github-project-automation github-project-automation bot moved this to Backlog in DVC Jan 15, 2026
@CLAassistant
Copy link

CLAassistant commented Jan 15, 2026

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.92%. Comparing base (2431ec6) to head (5f2a71a).
⚠️ Report is 187 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10971      +/-   ##
==========================================
+ Coverage   90.68%   90.92%   +0.23%     
==========================================
  Files         504      505       +1     
  Lines       39795    41084    +1289     
  Branches     3141     3249     +108     
==========================================
+ Hits        36087    37354    +1267     
- Misses       3042     3083      +41     
+ Partials      666      647      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@skshetry
Copy link
Collaborator

Have you tested this locally? Also, does this PR work with this constraint we have in pyproject.toml?

"pyparsing>=2.4.7",

@ritoban23
Copy link
Contributor Author

@skshetry Thanks for pointing it out...Just checked the change won't work with current pyparsing>=2.4.7 constraint since parse_all wasn't introduced until pyparsing 3.0.0. We'd need to either bump the constraint or keep using the old parseAll parameter.

@skshetry
Copy link
Collaborator

skshetry commented Jan 16, 2026

@skshetry Thanks for pointing it out...Just checked the change won't work with current pyparsing>=2.4.7 constraint since parse_all wasn't introduced until pyparsing 3.0.0. We'd need to either bump the constraint or keep using the old parseAll parameter.

Since that was released more than 4 years ago, I think it's okay to update the constraint to >=3.0.0.

Also, did you check before and after this PR on whether DeprecationWarning gets raised or not?

@ritoban23
Copy link
Contributor Author

Also, did you check before and after this PR on whether DeprecationWarning gets raised or not?

Yes checked for the deprecation warning

@skshetry skshetry merged commit 3c71fdb into treeverse:main Jan 16, 2026
15 of 45 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in DVC Jan 16, 2026
@skshetry
Copy link
Collaborator

Thank you. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dvc/parsing/interpolate.py uses Deprecated parseAll. switch to parse_all

3 participants