fix: replace deprecated parseAll with parse_all in interpolate.py#10971
fix: replace deprecated parseAll with parse_all in interpolate.py#10971skshetry merged 2 commits intotreeverse:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10971 +/- ##
==========================================
+ Coverage 90.68% 90.92% +0.23%
==========================================
Files 504 505 +1
Lines 39795 41084 +1289
Branches 3141 3249 +108
==========================================
+ Hits 36087 37354 +1267
- Misses 3042 3083 +41
+ Partials 666 647 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Have you tested this locally? Also, does this PR work with this constraint we have in Line 67 in 04cbd40 |
|
@skshetry Thanks for pointing it out...Just checked the change won't work with current |
Since that was released more than 4 years ago, I think it's okay to update the constraint to Also, did you check before and after this PR on whether DeprecationWarning gets raised or not? |
Yes checked for the deprecation warning |
|
Thank you. 🙂 |
Fixes #10968
Description
Replaced the deprecated
parseAllparameter with the PEP8-compliantparse_allparameter in theparseStringmethod call.Changes
dvc/parsing/interpolate.pyto useparse_all=Trueinstead ofparseAll=True❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.