Conversation
Support pathspec v1
Support pathspec v1
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10951 +/- ##
==========================================
+ Coverage 90.68% 90.98% +0.29%
==========================================
Files 504 505 +1
Lines 39795 41103 +1308
Branches 3141 3258 +117
==========================================
+ Hits 36087 37396 +1309
- Misses 3042 3069 +27
+ Partials 666 638 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Contributor
Author
|
There's a bug fix to not strip leading whitespace to match Git. This a minor edge case.
There is one potential major change to GitIgnoreSpecPattern (formerly GitWildMatchPattern) depending on how you use the resulting regular expressions. Some patterns will be optimized to match only part of the path string instead of the whole string. This largely affects "**" and "*". E.g., "**" will result in just "." instead of "^[^/]+(?:/.*)?$", and "**/" results in just f"(?P<{_DIR_MARK}>/)" instead of f"^.+(?P<{_DIR_MARK}>/).*$" [corrected].
…-------- Original Message --------
On Tuesday, 01/06/26 at 09:22 skshetry ***@***.***> wrote:
skshetry left a comment [(treeverse/dvc#10951)](#10951 (comment))
***@***.***(https://github.com/cpburnz), are there any behavior change in how the patterns are interpreted in v1?
By "substantial change" in [#10948](#10948), I was worried more about behavioral differences than API changes. We likely don’t have enough tests in DVC to validate that.
—
Reply to this email directly, [view it on GitHub](#10951 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAQHBW2NDQ7BLPJMYOHCF7D4FPAKTAVCNFSM6AAAAACQ2X367WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMJUHA4TANRUGA).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Contributor
Author
|
Additionally, the ending of regular paths changed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm the author of pathspec and released v1 yesterday. It was reported to me in #99 that this broke dvc, and you pinned to
pathspec<1in #10948. The changes required to support v1 are minimal:❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Here's the pytest summary: