Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10922 +/- ##
==========================================
+ Coverage 90.68% 90.99% +0.31%
==========================================
Files 504 505 +1
Lines 39795 41112 +1317
Branches 3141 3255 +114
==========================================
+ Hits 36087 37410 +1323
- Misses 3042 3064 +22
+ Partials 666 638 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ed33d83 to
10383e1
Compare
10383e1 to
312753e
Compare
312753e to
37398ea
Compare
37398ea to
3a821ca
Compare
Contributor
Author
|
I think there are some flaky tests :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
TODO
--jobsargument to CLIOTHER THOUGHTS
Obviously, when adding a feature like parallel execution, one of the first objections will be something like "but what if two stages can't run in parallel?". The quick answer is: then don't run in parallel!
But I think it would also be pretty easy to accommodate this in a fairly generic way. For example:
Probably self-explanatory, but the idea behind this is:
I'd be happy to contribute a follow-up PR with the
mutexfeature, if you like the idea