Open
Conversation
hendrawd
reviewed
May 20, 2021
| @@ -0,0 +1,5 @@ | |||
| <vector android:height="24dp" android:tint="#FFFFFF" | |||
There was a problem hiding this comment.
Maybe you can rename this file as ic_subtract instead? Because the button's purpose is to subtracting, not removing the number.
Or maybe it's better if the name follows the views ids as below:
- ic_add.xml -> ic_increment.xml
- ic_remove.xml -> ic_decrement.xml
hendrawd
reviewed
May 20, 2021
| numberpicker:max="10" | ||
| numberpicker:min="0" | ||
| numberpicker:unit="1" | ||
| numberpicker:value="-5" /> |
There was a problem hiding this comment.
Will it create an error? Because the min value is 0 but you set a negative number (below 0) as the value.
hendrawd
reviewed
May 20, 2021
| numberpicker:min="0" | ||
| numberpicker:unit="1" | ||
| numberpicker:custom_layout="@layout/number_picker_custom_layout" /> | ||
| numberpicker:value="-5" /> |
|
@travijuu IMHO this is a good improvement since it will increase the flexibility of the library. |
|
This PR will solve #4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use the AppCompatImageButton for inc/dec buttons. This caused the