Skip to content

Conversation

@TheyCodeMeSilvers
Copy link
Contributor

@TheyCodeMeSilvers TheyCodeMeSilvers commented Oct 2, 2025

Fixes #549

Description

adjusts the discriminatedUnion syntax Issue: 549

Checklist

  • My PR's title follows the gitmoji specification
  • My PR references any related issues
  • Any new feature or breaking change must come with an associated Issue or Discussion
  • Any added dependency must include an associated Issue or Discussion
  • My PR adds relevant tests that they would have failed without my PR (when applicable)

Advanced

  • Category: 🐛

@ahrjarrett
Copy link
Member

Looks good!

Will you do me a favor and run pnpm i && pnpm vitest and update the snapshots by pressing u in your terminal once the test fails?

Once that's done the CICD build should pass.

@TheyCodeMeSilvers TheyCodeMeSilvers force-pushed the fix-discriminated-union-to-string-mapping branch from d74a0e4 to c1aa2aa Compare October 2, 2025 14:03
@TheyCodeMeSilvers
Copy link
Contributor Author

Ah, sorry missed the snapshots, should be updated now

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 2, 2025

Open in StackBlitz

@traversable/arktype

npm i https://pkg.pr.new/traversable/schema/@traversable/arktype@551

@traversable/arktype-test

npm i https://pkg.pr.new/traversable/schema/@traversable/arktype-test@551

@traversable/arktype-types

npm i https://pkg.pr.new/traversable/schema/@traversable/arktype-types@551

@traversable/json

npm i https://pkg.pr.new/traversable/schema/@traversable/json@551

@traversable/json-schema

npm i https://pkg.pr.new/traversable/schema/@traversable/json-schema@551

@traversable/json-schema-test

npm i https://pkg.pr.new/traversable/schema/@traversable/json-schema-test@551

@traversable/json-schema-types

npm i https://pkg.pr.new/traversable/schema/@traversable/json-schema-types@551

@traversable/registry

npm i https://pkg.pr.new/traversable/schema/@traversable/registry@551

@traversable/schema

npm i https://pkg.pr.new/traversable/schema/@traversable/schema@551

@traversable/schema-codec

npm i https://pkg.pr.new/traversable/schema/@traversable/schema-codec@551

@traversable/schema-compiler

npm i https://pkg.pr.new/traversable/schema/@traversable/schema-compiler@551

@traversable/schema-deep-equal

npm i https://pkg.pr.new/traversable/schema/@traversable/schema-deep-equal@551

@traversable/schema-errors

npm i https://pkg.pr.new/traversable/schema/@traversable/schema-errors@551

@traversable/schema-seed

npm i https://pkg.pr.new/traversable/schema/@traversable/schema-seed@551

@traversable/schema-to-json-schema

npm i https://pkg.pr.new/traversable/schema/@traversable/schema-to-json-schema@551

@traversable/schema-to-string

npm i https://pkg.pr.new/traversable/schema/@traversable/schema-to-string@551

@traversable/schema-to-validator

npm i https://pkg.pr.new/traversable/schema/@traversable/schema-to-validator@551

@traversable/typebox

npm i https://pkg.pr.new/traversable/schema/@traversable/typebox@551

@traversable/typebox-test

npm i https://pkg.pr.new/traversable/schema/@traversable/typebox-test@551

@traversable/typebox-types

npm i https://pkg.pr.new/traversable/schema/@traversable/typebox-types@551

@traversable/valibot

npm i https://pkg.pr.new/traversable/schema/@traversable/valibot@551

@traversable/valibot-test

npm i https://pkg.pr.new/traversable/schema/@traversable/valibot-test@551

@traversable/valibot-types

npm i https://pkg.pr.new/traversable/schema/@traversable/valibot-types@551

@traversable/zod

npm i https://pkg.pr.new/traversable/schema/@traversable/zod@551

@traversable/zod-test

npm i https://pkg.pr.new/traversable/schema/@traversable/zod-test@551

@traversable/zod-types

npm i https://pkg.pr.new/traversable/schema/@traversable/zod-types@551

commit: c1aa2aa

Copy link
Member

@ahrjarrett ahrjarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrjarrett ahrjarrett merged commit 6b5ee2e into traversable:main Oct 2, 2025
4 checks passed
ahrjarrett added a commit that referenced this pull request Oct 2, 2025
…tring-mapping-changeset

chore: adds changelog for #551 fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discriminated unions .toString() incorrectly order params

2 participants