This repository was archived by the owner on Dec 1, 2025. It is now read-only.
Introduced twTasks.processing.triggersLimit gauge to show how many triggers we can keep in memory for a bucket.
#228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…triggers we can keep in memory for a bucket.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new metrics gauge twTasks.processing.triggersLimit to expose the maximum number of triggers that can be kept in memory for each bucket. This adds observability to help monitor and understand the memory constraints for trigger processing.
- Added new gauge metric to track triggers limit per bucket
- Refactored bucket properties retrieval to avoid duplicate calls
- Updated version and changelog documentation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| TasksProcessingService.java | Refactored bucket properties access and registered new triggers limit gauge |
| ICoreMetricsTemplate.java | Added interface method for registering triggers limit gauge |
| CoreMetricsTemplate.java | Implemented triggers limit gauge registration with metric constant |
| gradle.properties | Bumped version from 1.51.1 to 1.51.2 |
| CHANGELOG.md | Added changelog entry for the new triggers limit gauge |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tw-tasks-core/src/main/java/com/transferwise/tasks/helpers/CoreMetricsTemplate.java
Outdated
Show resolved
Hide resolved
tw-peeterkarolin
approved these changes
Aug 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Introduced
twTasks.processing.triggersLimitgauge to show how many triggers we can keep in memory for a bucket.Checklist