Collect basic request metrics and expose using GoLang's expvar#22
Open
yinonavraham wants to merge 4 commits intotraefik:masterfrom
Open
Collect basic request metrics and expose using GoLang's expvar#22yinonavraham wants to merge 4 commits intotraefik:masterfrom
yinonavraham wants to merge 4 commits intotraefik:masterfrom
Conversation
For every request, the following metrics are updated: - totalRequestCount - the total number of requests since the application started - concurrentRequestCount - the current number of concurrent requests - maxConcurrentRequestCount - the maximum number of concurrent requests since the application started Metrics are disabled by default, to preserve the current behavior and performance. To enable metrics, run the application with the '-metrics' command line flag. To get the current metrics values, use the following request path: GET /debug/vars
Contributor
Author
|
Can someone please review this PR, approve or reject? Any feedback is welcome... I really don't like to keep PRs open for long time - they don't age well... |
f805ee2 to
f9496aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For every request, the following metrics are updated:
totalRequestCount- the total number of requests since the application startedconcurrentRequestCount- the current number of concurrent requestsmaxConcurrentRequestCount- the maximum number of concurrent requests since the application startedMetrics are disabled by default, to preserve the current behavior and performance. To enable metrics, run the application with the '-metrics' command line flag. To get the current metrics values, use the following request path:
The impact of collecting request metrics when enabled on the performance is very low (see example below). When metrics are disabled there is no impact what-so-ever.
Example
Benchmark without metrics:
Benchmark with metrics enabled: