Updated to have pyperry put default_params into the query string#15
Open
jcredding wants to merge 4 commits intotpett:masterfrom
Open
Updated to have pyperry put default_params into the query string#15jcredding wants to merge 4 commits intotpett:masterfrom
default_params into the query string#15jcredding wants to merge 4 commits intotpett:masterfrom
Conversation
… for any pyperry.Base object.
…eated by reloading.
Currently the adapter only put default params in the body of POST/PUT/DELETE requests. This changes it to put the default params in the query string of all requests. This is to conform how default params are handled regardless of the request type and to also follow the ruby version of perry.
Author
|
@tpett This is the same kind of change that Kelly did for perry. We thought we'd send it your way. |
Updates to association.py from Ryan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the adapter only put default params in the body of POST/PUT/DELETE requests. This changes it to put the default params in the query string of all requests. This is to conform how default params are handled regardless of the request type and to also follow the ruby version of perry.