Set app description correctly on create only #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vements - Change towerfile desc. to Option<String> to distinguish absence and explicit empty - Add ApiCreateError for more accurate error reporting on app createion - Add UnexpectedApiResponse error to prevent silent description synchronization skip - Simplify error conversion in `ensure_app_exists`
Change from diff-checking approach to "latest wins" semantics; - Always update description on deploy when present (no comparison) - Skip update for empty/None (preserves server state) - Remove spinner and entity validation (simpler, more resilient)
bradhe
approved these changes
Jan 23, 2026
Contributor
bradhe
left a comment
bradhe
left a comment
There was a problem hiding this comment.
This is really great, thanks for taking care of this @burakdede! I'll leave this open in case there's any modifications you want to make, but will merge it over the weekend!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the description issue reported #166.
As evident from the commits I changed my mind quite a bit about where, when
descriptionmetadata should be applied eventually settled to scope it to only create flows and applied optional semantics of the field. (deployseemed too critical and applied too frequent to constantly sync this)High level changes;
descriptionto the API’sshort_descriptionon create (including deploy --create), and deploy no longer updates description for existing apps.