Fix string formatting in exception constructors across codebase#3578
Open
bysiber wants to merge 1 commit intotornadoweb:masterfrom
Open
Fix string formatting in exception constructors across codebase#3578bysiber wants to merge 1 commit intotornadoweb:masterfrom
bysiber wants to merge 1 commit intotornadoweb:masterfrom
Conversation
Several exception raise statements across the codebase use a comma
instead of % for string formatting, e.g.:
raise ValueError("message %s", value)
instead of:
raise ValueError("message %s" % value)
This causes the exception to store a tuple as its message rather
than a properly formatted string, making error messages confusing
and harder to debug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several
raisestatements across the codebase pass format arguments to exception constructors using a comma instead of%operator:When Python's
Exception.__init__receives multiple arguments,str(e)shows the raw tuple representation instead of a formatted message. For example,ValueError("unsupported auth_mode %s", "digest")displays as:instead of:
Affected locations:
web.py:_convert_header_value,xsrf_token,stream_request_body,_has_stream_request_bodywebsocket.py:_PerMessageDeflateCompressor.__init__,_PerMessageDeflateDecompressor.__init__,_process_server_headerssimple_httpclient.py: HTTP basic auth mode validationnetutil.py: Unix socket bind validationconcurrent.py:run_on_executorargument validation