Fix #22 Use importer callbacks to handle static path prefixes#58
Open
deshipu wants to merge 1 commit intotorchbox:mainfrom
Open
Fix #22 Use importer callbacks to handle static path prefixes#58deshipu wants to merge 1 commit intotorchbox:mainfrom
deshipu wants to merge 1 commit intotorchbox:mainfrom
Conversation
Instead of import paths, use the importer callback so we can handle static paths prefixes, and possibly also non-filesystem storage. This is more complicated than anticipated, because we have to re-create the fallback mechanisms for handling partials and extensions, and because finders.find ignores prefixes. There is probably room for improvement, especially around the source maps, but this is a start. Note that the test_raw_css_import test had to be changed, because the libsass doesn't seem to use @import when callbacks are used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of import paths, use the importer callback so we can handle static paths prefixes, and possibly also non-filesystem storage.
This is more complicated than anticipated, because we have to re-create the fallback mechanisms for handling partials and extensions, and because finders.find ignores prefixes.
There is probably room for improvement, especially around the source maps, but this is a start.
Note that the test_raw_css_import test had to be changed, because the libsass doesn't seem to use @import when callbacks are used.