Fix profile loading (param-manager UI) #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug where the parameter manager GUI would crash when closing and reopening the parameter manager tab. The issue was in the ProfilesManager.refresh() method which was comparing the full profile filename with the cleaned profile name, causing them to never match. The fix ensures profile names are cleaned before comparison, allowing the currently selected profile to be properly restored when refreshing the profile list. Changes: - Fixed profile name comparison in ProfilesManager.refresh() to use cleanProfileName() for both sides of the comparison - Added CLAUDE.md documentation for the instrumentserver codebase Labcore Changes: - Also added CLAUDE.md documentation for labcore - Profile files and serverConfig.yml added to labcore for testing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…in the parameter-manager window and then the window was closed, instrumentserver would crash upon ropening the parameter-manager window. Issue was that attributes from the profile were trying to be loaded when launching parameter-manager profile, where they don't exist. Fix - added try-except to handle the AttributeError when relaunching parameter-manager window to stop crashes when receiving broadcasts from parameters in a different profile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug that occurred when loading profiles in parameter-manager
Why - bug occurred because the user closed the param-manager on a profile other than "parameter-manager" and then tried to reopen the window. Old attribute updates (from the other profile) that did not exist anymore were being sent to parameter_manager, which was trying to load the "parameter-manager" profile attributes.