Made it possible to customise the split regex.#3
Open
ecker00 wants to merge 2 commits intotonygambone:masterfrom
Open
Made it possible to customise the split regex.#3ecker00 wants to merge 2 commits intotonygambone:masterfrom
ecker00 wants to merge 2 commits intotonygambone:masterfrom
Conversation
Owner
|
@ecker00 I like this! Before I merge it, I'd like to see a unit test added with a custom split regex... maybe also one on a non-HTML file type, since this would now open things up to splitting CSS files, etc. If I get the chance I'll add one, but if you want to add that to the PR that'd be awesome as well. Thanks! |
Author
|
That's great. Unfortunately, I'm not familiar with unit test driven development and don't have the opportunity to dive into learning it yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made a relative small change which makes this plugin much more flexible. It's now possible to pass the
splitStroption with a regex value to be used for splitting the files.In our build we use this together with Handlebars templates, for my preference a html comment with the filename is visually too subtile.