Skip to content

Fix ic textobject mapping and document it #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atomictom wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix ic textobject mapping and document it #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee03e6e
Fix string concatenation for ic textobject mapping
atomictom Dec 30, 2019
5af53f4
Add docs for the ic text object
atomictom Dec 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/tags
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,5 @@ tcomment-debug tcomment.txt /*tcomment-debug*
tcomment-maps tcomment.txt /*tcomment-maps*
tcomment-new-filetype tcomment.txt /*tcomment-new-filetype*
tcomment-operator tcomment.txt /*tcomment-operator*
tcomment-textobject tcomment.txt /*tcomment-textobject*
tcomment.txt tcomment.txt /*tcomment.txt*
12 changes: 12 additions & 0 deletions doc/tcomment.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,14 @@ A secondary set of key maps is defined for normal and insert mode (see also
<Leader>__ :: :TComment
<Leader>_i :: :TCommentInline

*tcomment-textobject*

A text object is also added for selecting an inner-comment:

{operator}ic :: Operate on the inner comment. The mapping can be changed
using the `g:tcomment_textobject_inlinecomment` variable
or disabled by setting it to the empty string, `''`.



-----------------------------------------------------------------------
Expand Down Expand Up @@ -256,6 +264,10 @@ g:tcomment_mapleader_uncomment_anyway (default: 'g<')
g:tcomment_mapleader_comment_anyway (default: 'g>')
See |tcomment-operator|.

*g:tcomment_textobject_inlinecomment*
g:tcomment_textobject_inlinecomment (default: 'ic')
See |tcomment-textobject|.

*:TComment*
:[range]TComment[!] ?ARGS...
If there is a visual selection that begins and ends in the same line,
Expand Down
4 changes: 2 additions & 2 deletions plugin/tcomment.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,8 @@ if g:tcomment_maps
exec 'xmap '. g:tcomment_mapleader_comment_anyway .' <Plug>TComment_Comment'
endif
if g:tcomment_textobject_inlinecomment != ''
exec 'vmap' g:tcomment_textobject_inlinecomment ' <Plug>TComment_ic'
exec 'omap' g:tcomment_textobject_inlinecomment ' <Plug>TComment_ic'
exec 'vmap '. g:tcomment_textobject_inlinecomment .' <Plug>TComment_ic'
Copy link
Owner

@tomtom tomtom Jan 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for the extra period here.

Copy link
Author

@atomictom atomictom Jan 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that to be consistent with the code a few lines above (all the other mappings use dots for string concat). But, I can remove it if you prefer (just let me know).

exec 'omap '. g:tcomment_textobject_inlinecomment .' <Plug>TComment_ic'
endif
endif

Expand Down