ROS 2 jazzy version of pointcloud_merger#8
Open
nino192 wants to merge 7 commits intotomlogan501:ros2from
Open
Conversation
Open
Owner
|
Do you have a rosbag for test purposes ? |
Author
|
@tomlogan501 I did not record it. I can record and send it friday. |
Author
|
@tomlogan501 I have recorded the bags but they are too big (233MB) to be uploaded here, where should I send them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the pointcloud_merger in ros2-jazzy and is meant to be merged into a new branch.
Changes:
concurrency_level,since threading is handled in the executor in ros2TimeSynchronizertoApproximateTimeSynchronizerwithmax_interval_durationparameter - I just couldn't get TimeSynchronizer to work properlystd::memcpyinstead ofPointCloud2Iterator- I needed the intensity field of the pointcloud in my use caseI have tested both node and component versions on 2 livox MID360 lidars.