Mcp stdio server #178
Mcp stdio server #178
Conversation
TUI now reads log paths from config and creates missing files before watching.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/mcp/mod.rs
Outdated
| assert!( | ||
| !response.contains("Content-Length:"), | ||
| "line-delimited response should not include headers" |
There was a problem hiding this comment.
The content_length_round_trip test asserts that a request framed with Content-Length should receive a headerless, newline-terminated response, but serve_stream deliberately emits Content-Length headers whenever the request includes headers (see lines 487-506). As written, this assertion will always fail when the ping is framed per MCP (with Content-Length), breaking the test suite rather than checking the real behavior.
Useful? React with 👍 / 👎.
src/mcp/mod.rs
Outdated
| assert!( | ||
| response.contains("Content-Length:"), | ||
| "response missing Content-Length header" |
There was a problem hiding this comment.
For a line-delimited ping request, serve_stream skips headers and replies with just the JSON body plus a trailing newline (it only adds Content-Length when headers were present in the request), but this test asserts that the response must contain a Content-Length header. That inverted expectation will make the test fail on every run, preventing CI from validating the intended no-header fallback path.
Useful? React with 👍 / 👎.
No description provided.