feat: improve bookmark tracking with auto-refresh and line number adjustments#31
Open
ESSO0428 wants to merge 2 commits intotomasky:mainfrom
Open
feat: improve bookmark tracking with auto-refresh and line number adjustments#31ESSO0428 wants to merge 2 commits intotomasky:mainfrom
ESSO0428 wants to merge 2 commits intotomasky:mainfrom
Conversation
…ling - Add automatic refresh on text changes (TextChanged, TextChangedI) - Implement buffer attachment tracking to prevent duplicate attachments - Add line number adjustment when text is inserted/deleted above bookmarks - Improve code formatting and indentation consistency throughout - Enhanced bookmark position persistence after line edits or undo operations The bookmark system now automatically updates when text changes occur, ensuring bookmarks remain accurately positioned even when lines are added, removed, or reverted via undo.
Add on_detach callback to nvim_buf_attach to properly remove buffer from attached_buffers table when buffer is detached. This prevents memory leaks and stale references in the attached_buffers tracking table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update improves the reliability of bookmark tracking in dynamic editing scenarios.
Changes
TextChanged,TextChangedI)Why
Previously, bookmark positions could become inaccurate after inserting lines or using undo operations. This change ensures that bookmarks are updated automatically, maintaining correct positioning across all typical editing actions.
Let me know if any changes are needed. Thanks!