Don't create/do remove bookmarks file when there are no bookmarks.#30
Open
obszczymucha wants to merge 1 commit intotomasky:mainfrom
Open
Don't create/do remove bookmarks file when there are no bookmarks.#30obszczymucha wants to merge 1 commit intotomasky:mainfrom
obszczymucha wants to merge 1 commit intotomasky:mainfrom
Conversation
obszczymucha
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for the plugin, it's great.
This change is motivated by the fact that once the bookmarks file is created it always remains there even if there are no bookmarks.
In my use case, I set up the plugin and set the save_file to point to the project's directory, so each project contains its own bookmarks.
This leaves a lot of bookmark files everywhere.
This change checks if there are bookmarks available, and if not it doesn't create the file. If there used to be bookmarks, but there are
none now, it deletes the bookmarks file to clean up.