Implementation of advanced search#206
Merged
tomasbedrich merged 22 commits intotomasbedrich:masterfrom Mar 28, 2023
BelKed:advanced-search
Merged
Implementation of advanced search#206tomasbedrich merged 22 commits intotomasbedrich:masterfrom BelKed:advanced-search
tomasbedrich merged 22 commits intotomasbedrich:masterfrom
BelKed:advanced-search
Conversation
…anced_search()` function
…g.advanced_search()` function
tomasbedrich
requested changes
Mar 25, 2023
Owner
|
Nice job overall. 💪🏼 It would definitely be useful to have another pair of eyes here. |
FriedrichFroebel
requested changes
Mar 27, 2023
Collaborator
FriedrichFroebel
left a comment
FriedrichFroebel
left a comment
There was a problem hiding this comment.
Thanks for the PR. I have marked some additional oddities which probably should be resolved before merging.
Contributor
Author
|
Weirdly, CI fails here, but it runs on my fork: |
Collaborator
|
I am not completely sure about the CI failures as well, but I do not really feel like this should be merged until we are able to resolve this. Maybe rebasing the code on the latest master change something here? |
Contributor
Author
|
I believe it's fine now :) |
FriedrichFroebel
approved these changes
Mar 27, 2023
Collaborator
|
Thanks, looks good for me. Re-requesting review from @tomasbedrich before merging. |
tomasbedrich
requested changes
Mar 27, 2023
tomasbedrich
approved these changes
Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new way of searching for caches using the search API, which allows using filters and much more (with the
Geocaching.advanced_search()method).This search method is also faster because it loads less data (the data is in JSON form). Data parsing is then easier and clearer.
Now we have a main search function —
Geocaching.advanced_search().Both
Geocaching.search()andGeocaching.search_rect()internally useGeocaching.advanced_search(), which reduces repeating code, since the implementation would be almost the same.I've also updated the docstrings for those functions and added some tests.
Related PR:
(Although, that PR uses a different approach by parsing HTML...)
Related issues:
Remote end closed connection without responsewhen usingGeocaching.search()#182