Add VUB parser and comprehensive README improvements#18
Merged
Conversation
### Added VUB Parser - Port VubMailParser from REMP2020 repository to proper directory structure - Support for VUB bank email parsing (Slovakia) in src/Parsers/Vub/ - Extract transaction date, amount, account numbers, VS/KS symbols - Comprehensive test coverage with real email format examples - Follows existing project patterns and namespace conventions ### Documentation Improvements - Professional bank support matrix with country flags and features - Quick Start guide with immediate usage example after installation - Complete MailContent API documentation with all available getters - Email format examples showing real bank email structures - Error handling guide with validation examples and common scenarios - Security considerations including PGP key management best practices - Contributing guidelines with step-by-step process for adding banks - Structured migration guides covering all major version changes - PHP/library compatibility matrix showing supported versions ### Technical Details - VUB parser handles Slovak bank confirmation emails with regex patterns - Extracts: transaction date, source account, amount, variable/constant symbols - All existing functionality preserved with 100% backward compatibility - 40/40 tests passing with comprehensive coverage - PHPStan analysis clean at existing level 5 configuration - No breaking changes to existing parser APIs or return types The VUB parser complements existing TatraBanka and ČSOB parsers, providing comprehensive coverage of major Slovak banking institutions.
- Fixed PSR2 compliance in VubMailParser.php - Fixed PSR2 compliance in VubMailParserTest.php - Applied via phpcbf automatic formatting
The Makefile is not referenced anywhere in the project: - GitHub Actions CI uses direct vendor/bin commands - README documentation uses composer scripts - No build scripts reference make targets Cleanup legacy file for cleaner project structure.
…sistency
- Moved src/Parsers/ to src/Parser/ to match namespace Tomaj\BankMailsParser\Parser- Moved tests/Parsers/ to tests/Parser/ for consistent structure
- All namespaces remain unchanged: Tomaj\BankMailsParser\Parser\{Bank}
- Regenerated autoload after directory restructure
- All 40 tests still passing, PHPStan clean
This improves project consistency where directory structure matches namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/Parsers/Vub/directoryNew VUB Parser Features
🏦 Bank Support
nonstopbanking@vub.sk📊 Extracted Data
🧪 Testing
Documentation Improvements
📚 Professional README Structure
🛡️ Security & Best Practices
🤝 Developer Experience
Technical Implementation
🏗️ Architecture
📁 File Structure
🔍 Code Quality
declare(strict_types=1)throughoutExample Usage
Testing Results
Impact
This PR expands the library's banking coverage to include VUB, one of Slovakia's largest banks, while significantly improving the developer experience through comprehensive documentation and examples.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com