-
-
Notifications
You must be signed in to change notification settings - Fork 326
feat: add manifest in generated files by exporter for Android SDK #3352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add manifest in generated files by exporter for Android SDK #3352
Conversation
📝 WalkthroughWalkthroughThe changes introduce a new Changes
Sequence DiagramsequenceDiagram
participant Client
participant JsonFileExporterWithManifest
participant JsonFileExporter
participant ObjectMapper
participant FileMap as File Map
Client->>JsonFileExporterWithManifest: produceFiles()
JsonFileExporterWithManifest->>JsonFileExporter: produceFiles()
JsonFileExporter->>JsonFileExporter: Generate JSON files
JsonFileExporter-->>JsonFileExporterWithManifest: JSON files map
JsonFileExporterWithManifest->>JsonFileExporterWithManifest: Extract locales from translations
JsonFileExporterWithManifest->>JsonFileExporterWithManifest: Sort & deduplicate locales
JsonFileExporterWithManifest->>ObjectMapper: Serialize manifest JSON
ObjectMapper-->>JsonFileExporterWithManifest: Manifest InputStream
JsonFileExporterWithManifest->>FileMap: Combine JSON files + manifest.json
FileMap-->>Client: Complete file map
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🧰 Additional context used📓 Path-based instructions (3)backend/**/*.kt📄 CodeRabbit inference engine (AGENTS.md)
Files:
backend/**/*Test.kt📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx,js,jsx,kt,kts}⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (2)📚 Learning: 2025-11-28T15:12:44.060ZApplied to files:
📚 Learning: 2025-11-28T15:12:44.060ZApplied to files:
🧬 Code graph analysis (1)backend/data/src/test/kotlin/io/tolgee/unit/formats/android/out/AndroidSdkFileExporterTest.kt (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (9)
Comment |
# [3.146.0](v3.145.5...v3.146.0) (2026-01-09) ### Features * add manifest in generated files by exporter for Android SDK ([#3352](#3352)) ([e2d9699](e2d9699))
Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.