Conversation
|
|
Failed to generate code suggestions for PR |
floscr
force-pushed
the
florian/graph-navigator
branch
from
179580a to
8ce784d
Compare
| const innerGraph = node['_innerGraph']; | ||
| if (!innerGraph) return null; |
There was a problem hiding this comment.
I don't know how we can get this type out of packages/graph-engine/src/nodes/generic/subgraph.ts so we can do a proper typescript type check.
I would have liked to do a check like
if (node instanceof SubgraphNode) {
const innerGraph = node._innerGraph;
if (!innerGraph) return null;
}
but I'm not sure how importing for types/classes works for such packages
| if (typeof window !== 'undefined') { | ||
| window['newGraphEditor'] = function (ref, id) { | ||
| return ( | ||
| <ErrorBoundary fallback={<ErrorBoundaryContent />}> | ||
| <GraphEditor ref={ref} id={id} /> | ||
| </ErrorBoundary> | ||
| ); | ||
| }; | ||
| } |
There was a problem hiding this comment.
NextJS was erroring because there's a circular dependency.
I think this is not too bad if we have some interface for global methods.
packages/graph-editor/src/components/panels/navigation/index.module.css
Outdated
Show resolved
Hide resolved
packages/graph-editor/src/components/panels/navigation/index.module.css
Outdated
Show resolved
Hide resolved
packages/graph-editor/src/components/panels/navigation/index.module.css
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| .listItemCount { | ||
| opacity: 0.5; |
There was a problem hiding this comment.
why the opacity here, to make it subtle?
There was a problem hiding this comment.
ok, this should be solved with using var(--fg-subtle)
There was a problem hiding this comment.
Changed, but looks almost indistinguishable imo (also I think --component-spacing-xs is too large)
packages/graph-editor/src/components/panels/navigation/index.tsx
Outdated
Show resolved
Hide resolved
packages/graph-editor/src/components/panels/navigation/index.tsx
Outdated
Show resolved
Hide resolved
2 participants
Adds a panel with which the user can easily navigate between subgraphs.
Open it under Layout -> Navigator
2024-12-20-18-51_02.mp4