Skip to content

Support for additional IRIS tracking modes#12

Open
tnakamot wants to merge 3 commits intomasterfrom
tnakamot/irisNewTrackingMode
Open

Support for additional IRIS tracking modes#12
tnakamot wants to merge 3 commits intomasterfrom
tnakamot/irisNewTrackingMode

Conversation

@tnakamot
Copy link
Contributor

This pull request includes the following changes:

  • Added new event coldStopMaskAngle. This was previously pupilRotation, but it was renamed because the cold stop mask angle can be different from the pupil rotation in special tracking modes (e.g., M1 tracking and DM0 tracking modes).
  • The old pupilRotation remains because the IRIS DRS subscribes to it. Tracking attributes (pointingstate and trackID) are now removed because pupilRotation won't be used for tracking anymore.
  • Revised the description of imgAtmDispersion and instrumentRotatorAngle to clarify that the TCS sends the correct angle taking into account the current tracking mode (normal tracking mode, M1 tracking mode or DM0 tracking mode).
  • Revised the description of imgAtmDispersion and coldStopMaskAngle because the IRIS software needs those demands 3 seconds before the time indicated by the timestamp attribute.

@tnakamot tnakamot changed the title Tnakamot/iris new tracking mode Support for additional IRIS tracking modes Mar 13, 2021
@edwardchapin edwardchapin requested a review from lianqiw March 15, 2021 17:58
Copy link
Contributor

@edwardchapin edwardchapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than requesting that @lianqiw confirm that we still need pupilRotation for the RPG, this PR looks good to me. We need the new coldStopMaskAngle event, and the updated Discussion clarifies things.

Copy link
Contributor

@lianqiw lianqiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RPG does need pupilRotation to properly rotate gradients from IRIS to NFIRAOS focal plane. This is not related to the Lyot mask.

…ask angle is the same as the pupil rotation in FCRS_IRIS-ROT.
@tnakamot
Copy link
Contributor Author

After some discussion with Ed, I made some modifications to this pull request. Now this pull request includes the following changes:

  • It is now clarified that "pupilRotation" may not be the same as the parallactic angle in special tracking modes (e.g., M1 tracking and DM0 tracking modes).
  • Revised the description of imgAtmDispersion and instrumentRotatorAngle to clarify that the TCS sends the correct angle taking into account the current tracking mode (normal tracking mode, M1 tracking mode or DM0 tracking mode).
  • Revised the description of imgAtmDispersion and coldStopMaskAngle because the IRIS software needs those demands "1 second" before the time indicated by the timestamp attribute. Added "TBC" mark to "1 second" because a concern about the accuracy of the future demand was raised.
  • Increased the rate of imgAtmDispersion from 1 Hz to 2 Hz.

@tnakamot tnakamot requested a review from edwardchapin March 18, 2021 19:25
Copy link
Contributor

@edwardchapin edwardchapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better now having reverted to using pupilRotation, but with the extra description to clarify things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants