feat: ✨ Implement azdo service-endpoint azurerm create command and apply fixes to other commands
#156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Azure DevOps pipeline permissions and approvals API clients. This includes: - PipelinePermissions client for managing resource pipeline permissions - PipelinesApproval client for handling approval workflows - PipelinesChecks client for check configurations and evaluations - TaskCheck client for task-based checks - Updated client factory and connection interfaces to support new clients - Vendor dependencies for the new Azure DevOps Go API packages
- Add project field and environment variable support - Implement thread-safe value store with SetValue/Value methods - Add stub prompter implementation for acceptance tests - Update test context to support project configuration - Add comprehensive test coverage for new functionality
Add functionality to grant all pipelines access to a service endpoint in Azure DevOps. Includes input validation, error handling with optional cleanup, and integration with the pipeline permissions API client.
- Consolidate reviewer flags: add/remove required/optional reviewers with single `--add-required-reviewer`, `--add-optional-reviewer`, and `--remove-reviewer` flags - Support wildcard (`*`) for removing all reviewers or labels - Add reviewer promotion/demotion between required and optional states - Improve label management with case-insensitive matching and wildcard support - Add comprehensive examples in command help text - Introduce reviewer intent tracking for more precise reviewer updates - Add input validation for flag combinations
Add labels field to pull request JSON output and display labels in the template. Include labels in the JSON exportable fields and render them in the view output when present.
Add `WriteTestFile` and `WriteTestFileWithName` functions to create temporary test files with random or specified names. Includes comprehensive test coverage for file creation, permissions, content validation, and error handling.
Tests verify endpoint creation, authentication scheme validation, and data integrity across different configuration scenarios. Includes temporary project provisioning, test resource cleanup, and polling mechanisms for async operations.
- update PR edit command to reflect new reviewer and label management features - add aliases for PR view (status) and project/service endpoint creation commands - improve JSON output options for PR view command - add grant permission flag for AzureRM service endpoint creation - standardize command examples and usage documentation
… and TestContext utilities - Add AZDO_ACC_PROJECT to acceptance test environment variables for project-scoped resource testing - Document new TestContext.Project() method and SetValue/Value helpers for cross-step data propagation - Add WriteTestFile utility for creating test files with proper permissions
Add explicit guidance for multi-value flag semantics using `*` as a sentinel value and mandate git-aware patches for file modifications. Also introduce a new section encouraging reuse of existing helpers from `internal/types`.
tmeckel
force-pushed
the
tmeckel/issue69
branch
from
c11b9ff to
ff71291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AzureRM Service Endpoint Creation and Pipeline Permissions Management
This pull request implements the
azdo service-endpoints create azurermcommand and adds comprehensive pipeline permissions management capabilities for service endpoints.Features
AzureRM Service Endpoint Creation ✨
azdo service-endpoints create azurerm- Create AzureRM service connections with full parameter supportPipeline Permissions Management 🔐
MapSliceandMapSlicePtrutility functions for safer slice transformationsPull Request Enhancements 🎯
c,cr) for project create commandTesting Infrastructure 🧪
Documentation Improvements 📄
AZDO_ACC_PROJECTenvironment variable and TestContext utilitiesChanges Summary
Major Features
azdo service-endpoints create azurermcommandEnhancements
Bug Fixes
Documentation
Testing
All changes include comprehensive test coverage:
Impact
This PR significantly enhances the Azure DevOps CLI with:
Closes: #69