Skip to content

CI: check all proofs without time limit #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahelwer merged 1 commit into from
Dec 15, 2025
Merged

CI: check all proofs without time limit #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/scripts/check_proofs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
parser = ArgumentParser(description='Validate all proofs in all modules with TLAPM.')
parser.add_argument('--tlapm_path', help='Path to TLAPM install dir; should have bin and lib subdirs', required=False, default = 'deps/tlapm')
parser.add_argument('--examples_root', help='Root directory of the tlaplus/examples repository', required=False, default='.')
parser.add_argument('--runtime_seconds_limit', help='Only run proofs with expected runtime less than this value', required=False, default=60)
parser.add_argument('--skip', nargs='+', help='Space-separated list of .tla modules to skip checking', required=False, default=[])
parser.add_argument('--only', nargs='+', help='If provided, only check proofs in this space-separated list', required=False, default=[])
parser.add_argument('--verbose', help='Set logging output level to debug', action='store_true')
Expand All @@ -24,17 +23,15 @@
manifest = tla_utils.load_all_manifests(examples_root)
skip_modules = args.skip
only_modules = args.only
hard_timeout_in_seconds = args.runtime_seconds_limit * 2

logging.basicConfig(level = logging.DEBUG if args.verbose else logging.INFO)

proof_module_paths = sorted(
[
(manifest_dir, spec, module, runtime)
(manifest_dir, spec, module, tla_utils.parse_timespan(module['proof']['runtime']))
for manifest_dir, spec in manifest
for module in spec['modules']
if 'proof' in module
and (runtime := tla_utils.parse_timespan(module['proof']['runtime'])) <= timedelta(seconds = args.runtime_seconds_limit)
and module['path'] not in skip_modules
and (only_modules == [] or module['path'] in only_modules)
],
Expand All @@ -61,8 +58,7 @@
],
stdout = subprocess.PIPE,
stderr = subprocess.STDOUT,
text = True,
timeout = hard_timeout_in_seconds
text = True
)
end_time = timer()
actual_runtime = timedelta(seconds = end_time - start_time)
Expand Down